introduce offer mints and accounts by gudnuf · Pull Request #959 · MakePrisms/agicash

gudnuf · 2026-03-25T23:14:58Z

Replace closed_loop boolean with a purpose enum (transactional | gift-card | offer) in mint info extensions. Offer mints have NUT-04 minting disabled and keyset-based expiry.

I will open follow up PRs that add the account state (active, expired, deleted), and one for the offers UI

Replace closed_loop boolean with a purpose enum (transactional | gift-card | offer) in mint info extensions. Offer mints have NUT-04 minting disabled and keyset-based expiry for promotional ecash distribution. - Add 'offer' to MintPurpose type and account_purpose DB enum - Add expiresAt field to CashuAccount (derived from active keyset final_expiry) - Allow NUT-04 disabled in mint validation for offer mints - Adapt canSendToLightning/canReceiveFromLightning for 3-purpose model - Update isTestMintQueryOptions to handle mints with minting disabled

vercel · 2026-03-25T23:15:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agicash	Ready	Preview, Comment	Mar 25, 2026 11:16pm

supabase · 2026-03-25T23:15:14Z

Updates to Preview Branch (add-offer-accounts) ↗︎

Deployments	Status	Updated
Database	✅	Wed, 25 Mar 2026 23:15:43 UTC
Services	✅	Wed, 25 Mar 2026 23:15:43 UTC
APIs	✅	Wed, 25 Mar 2026 23:15:43 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks	Status	Updated
Configurations	⚠️	Wed, 25 Mar 2026 23:19:05 UTC
Migrations	✅	Wed, 25 Mar 2026 23:19:09 UTC
Seeding	✅	Wed, 25 Mar 2026 23:19:09 UTC
Edge Functions	✅	Wed, 25 Mar 2026 23:19:09 UTC

⚠️ Warning — Service health check failed

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

gudnuf · 2026-03-26T08:36:35Z

app/features/agicash-db/json-models/cashu-account-details-db-data.ts

+   * Converted from the active keyset's `final_expiry` unix epoch (NUT-02).
+   * Null for non-offer accounts or when the keyset has no expiry.
+   */
+  expires_at: z.string().nullable().optional(),


looking at this plan for adding account state here I'm wondering if expires_at should be a new column, not in the cashu account jsonb.

I think it should. See my comment here. Do you see some benefits of it being in cashu jsonb?

jbojcic1 · 2026-04-02T13:13:46Z

app/lib/cashu/protocol-extensions.ts

+ * The purpose of a Cashu mint as advertised in its info response.
+ * - 'transactional': Regular mint for sending/receiving payments
+ * - 'gift-card': Closed-loop mint issuing gift cards
+ * - 'offer': Promotional ecash with an expiry


nit but should we mention that this one is closed loop too?

jbojcic1 · 2026-04-02T13:17:06Z

app/lib/cashu/utils.ts

+    return false;
+  }
  const wallet = getCashuWallet(mintUrl);
  const { request: bolt11 } = await wallet.createMintQuoteBolt11(1);


should we just remove this check since we discussed how it doesn't work anyway? maybe we should just consider it a test mint if included in knownTestMints

jbojcic1 · 2026-04-02T13:18:25Z

app/lib/cashu/utils.ts

+ * Assumes one active keyset per unit on offer mints.
+ * @returns The ISO 8601 timestamp when the offer expires, or null if the keyset has no expiry.
+ */
+export const getOfferExpiresAt = (


I would probably have this function return Date | null and then the caller can convert to iso string if needed

Also I think this function should be called getKeysetExpiry or getMintExpiry or something like that since it doesn't do anything purpose specific.

jbojcic1 · 2026-04-02T13:21:16Z

app/features/accounts/account.ts

+ * plus 'transactional' which also applies to non-cashu account types (e.g. Spark).
 */
-export type AccountPurpose = 'transactional' | 'gift-card';
+export type AccountPurpose = 'transactional' | MintPurpose;


but transactional already exists on MintPurpose so should be enough to do export type AccountPurpose = MintPurpose

jbojcic1 · 2026-04-02T13:23:41Z

app/features/accounts/account.ts

+       * Converted from the active keyset's `final_expiry` unix epoch (NUT-02).
+       * Null for non-offer accounts.
+       */
+      expiresAt: string | null;


I wonder if account expiry should be top level account concept and not cashu specific thing. Similar to how purpose is atm even though for Spark it is always transactional atm.

jbojcic1 · 2026-04-02T13:25:08Z

app/features/accounts/account.ts

 /**
 * Returns true if the account can send payments through the Lightning network.
- * Returns false for test mints and gift-card accounts.
+ * Returns false for offline wallets, test mints, non-transactional accounts,


why did we change this to check online status too now? if we are doing that shouldn't we check only status for spark type too?

jbojcic1 · 2026-04-02T13:26:00Z

app/features/agicash-db/json-models/cashu-account-details-db-data.ts

+   * Converted from the active keyset's `final_expiry` unix epoch (NUT-02).
+   * Null for non-offer accounts or when the keyset has no expiry.
+   */
+  expires_at: z.string().nullable().optional(),


I think it should. See my comment here. Do you see some benefits of it being in cashu jsonb?

jbojcic1 · 2026-04-02T13:41:57Z

app/lib/cashu/utils.ts

+  currency: Currency,
+): string | null => {
+  const unit = getCashuProtocolUnit(currency);
+  const activeKeyset = keysets.find((ks) => ks.unit === unit && ks.active);


can there be more than one active keyset for the same unit?

jbojcic1 · 2026-04-02T13:47:24Z

app/features/shared/cashu.ts

+  mintInfo: ExtendedMintInfo,
+) => {
+  return queryOptions({
+    queryKey: ['is-test-mint', mintUrl, mintInfo.isSupported(4).disabled],


what is this change for?

jbojcic1 · 2026-04-02T13:56:31Z

app/features/accounts/account-service.ts

      | 'isOnline'
    >;
  }) {
-    const isTestMint = await checkIsTestMint(account.mintUrl);


why can't this be a simple fn call anymore?

gudnuf requested a review from jbojcic1 March 25, 2026 23:14

gudnuf self-assigned this Mar 25, 2026

vercel bot deployed to Preview March 25, 2026 23:16 View deployment

gudnuf commented Mar 26, 2026

View reviewed changes

orveth mentioned this pull request Mar 26, 2026

feat: add offer account support (MVP) #955

Closed

7 tasks

orveth assigned ditto-agent, jbojcic1 and gudnuf and unassigned gudnuf, ditto-agent and jbojcic1 Mar 27, 2026

orveth requested review from ditto-agent and removed request for jbojcic1 March 28, 2026 09:20

gudnuf changed the title ~~feat: add offer mint purpose to cashu protocol extensions~~ introduce offer mints and accounts Mar 28, 2026

orveth mentioned this pull request Mar 30, 2026

Wire offer accounts into gift card UI #967

Open

gudnuf mentioned this pull request Mar 31, 2026

feat: add offers UI with card display and details page #968

Open

jbojcic1 reviewed Apr 2, 2026

View reviewed changes

Conversation

gudnuf commented Mar 25, 2026

Uh oh!

vercel bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Mar 25, 2026 •

edited

Loading

supabase bot commented Mar 25, 2026 •

edited

Loading